meetjunsu commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r737202866



##########
File path: 
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##########
@@ -141,6 +163,11 @@ private FieldWriter createWriter(LogicalType t, Type type) 
{
         public void write(RowData row, int ordinal) {
             recordConsumer.addBoolean(row.getBoolean(ordinal));
         }
+
+        @Override
+        public void write(Object value) {
+            recordConsumer.addBoolean((boolean) value);

Review comment:
       If the value is `null`, the `isNullAt` method has been called before, so 
there is no need to write a null value here, Flink does not support read 
composite type now , I will add test cases later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to