[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355334#comment-15355334
]
ASF GitHub Bot commented on FLINK-3618:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2184
[FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather
implementation
Rename MessageFunction to ScatterFunction and VertexUpdateFunction to
GatherFunction.
Change the parameter order in
Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction) to
Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
3618_rename_abstract_udf_classes_in_scatter_gather_implementation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2184
----
commit 9dd51074104184a5cb6e69affa5775a91de4d9a4
Author: Greg Hogan <[email protected]>
Date: 2016-05-06T19:39:38Z
[FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather
implementation
Rename MessageFunction to ScatterFunction
and VertexUpdateFunction to GatherFunction.
Change the parameter order in
Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction)
to
Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)
----
> Rename abstract UDF classes in Scatter-Gather implementation
> ------------------------------------------------------------
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.1.0, 1.0.1
> Reporter: Martin Junghanns
> Assignee: Greg Hogan
> Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
