twalthr commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r740020822
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -979,6 +1265,30 @@ private TestSpec build() {
.testResult(testSpecs.toArray(new ResultSpec[0]));
return testSpec;
}
+
+ private String tableApiSpecificErrorMsg(int i, LogicalType colType,
String defaultMsg) {
Review comment:
this looks like duplicate code to me that can be merged with the method
below? also `i` is not used.
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -88,9 +130,10 @@ protected Configuration configuration() {
// https://issues.apache.org/jira/browse/FLINK-24413 -
Trim to precision
// in this case down to 3 chars
.fromCase(STRING(), "abcdef", "abcdef") // "abc"
- .fromCase(DATE(), LocalDate.parse("2021-09-30"),
"2021-09-30") // "202"
+ .fromCase(DATE(), DEFAULT_DATE, "2021-09-24") // "202"
Review comment:
What was the `202` referring to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
