guoweiM commented on a change in pull request #17:
URL: https://github.com/apache/flink-ml/pull/17#discussion_r740036597
##########
File path:
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/allround/AbstractAllRoundWrapperOperator.java
##########
@@ -99,19 +99,18 @@ public AbstractAllRoundWrapperOperator(
@Override
public void onEpochWatermarkIncrement(int epochWatermark) throws
IOException {
- if (epochWatermark <= latestEpochWatermark) {
- return;
+ if (epochWatermark > latestEpochWatermark) {
+ latestEpochWatermark = epochWatermark;
+
+ setIterationContextRound(epochWatermark);
+ processOperatorOrUdfIfSatisfy(
+ wrappedOperator,
+ IterationListener.class,
+ listener -> notifyEpochWatermarkIncrement(listener,
epochWatermark));
+ clearIterationContextRound();
}
- latestEpochWatermark = epochWatermark;
- setIterationContextRound(epochWatermark);
- processOperatorOrUdfIfSatisfy(
- wrappedOperator,
- IterationListener.class,
- listener -> notifyEpochWatermarkIncrement(listener,
epochWatermark));
- clearIterationContextRound();
-
- // Broadcast the events.
+ // Always broadcast the events.
Review comment:
broadcasts？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
