zentol edited a comment on pull request #17606:
URL: https://github.com/apache/flink/pull/17606#issuecomment-956207150
That test failure is driving me crazy.
With the original code the test passes.
```
resultFuture
.whenComplete(
(resultValue, failure) -> {
if (failure != null) {
completableFuture.completeExceptionally(
resolveTimeoutException(
failure,
callStackCapture, address, rpcInvocation));
} else {
completableFuture.complete(
deserializeValueIfNeeded(resultValue, method));
}
});
```
If I move the deserialization into a separate thenApply then it fails.
```
resultFuture
.thenApply(resultValue ->
deserializeValueIfNeeded(resultValue, method))
.whenComplete(
(resultValue, failure) -> {
if (failure != null) {
completableFuture.completeExceptionally(
resolveTimeoutException(
failure,
callStackCapture, address, rpcInvocation));
} else {
completableFuture.complete(resultValue);
}
});
```
Sure, I could explain it if `deserializeValueIfNeeded` throws an exception,
but that's not the case. 💢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
