godfreyhe commented on pull request #17444: URL: https://github.com/apache/flink/pull/17444#issuecomment-957391630
@twalthr Thanks for driving this. I will pay more attention to the code quality of test cases. Currently, `select 1 = '1'` will generate wrong result, and all Flink (SQL) versions will be affected. About master, two solutions: 1) revert this commit, 2) or improve the test code and remove the validation code after the cast rule cover this bug. About other branches, we will not pick the cast feature to the lower versions, so just improve the test code. Improving the test case is common action, the second solution for master branch is better ? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
