JingGe opened a new pull request #17656:
URL: https://github.com/apache/flink/pull/17656


   ## What is the purpose of the change
   
   The FileRecordFormat and StreamFormat have too much commons. This makes user 
confused. The main motivation for removing it is the inherent design flaw in 
the batching of FileRecordFormat: StreamFormat can guarantee that only a 
certain amount of memory is being used (unless a single record exceeds that 
already), but FileRecordFormat can only batch by the number of records. By 
removing FileRecordFormat, we relay the responsibility of implementing the 
batching to the format developer; they need to use BulkFormat and find a better 
way than batch by number of records.
   
   
   ## Brief change log
   
   - marked FileRecordFormat and FileRecordFormatAdapter as @Deprecated.
   - refactored the relevant usages.
   - updated javadoc.
   
   
   
   ## Verifying this change
   
   This change only marked some classes as deprecated and update relevant 
comments without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to