rkhachatryan commented on a change in pull request #17645:
URL: https://github.com/apache/flink/pull/17645#discussion_r741871620
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockKeyedStateBackend.java
##########
@@ -221,9 +226,11 @@ public void notifyCheckpointAborted(long checkpointId) {
@Nonnull CheckpointOptions checkpointOptions) {
return new FutureTask<>(
() ->
- SnapshotResult.of(
- new MockKeyedStateHandle<>(
- copy(stateValues,
stateSnapshotFilters))));
+ emptySnapshot
Review comment:
A non-empty snapshot can't be handled by JM because
`MockKeyedStateHandle` can't be serialized by MetadataSerializer. Adding a
branch to (de)serialize mock state handle to production code doesn't seem right
to me, so I decided to have an empty snapshot instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]