matriv commented on pull request #17658:
URL: https://github.com/apache/flink/pull/17658#issuecomment-959587919


   > @matriv regarding testing the rules in `CastFunctionsITCase`, I 
effectively found out that the row, array and map rules doesn't work, because 
some validation steps before (`SqlValidatorImpl` and `LogicalTypeCasts`) thinks 
the cast combination is invalid. Because the goal of this PR is to simply port 
the logic from `ScalarOperatorGens` to the new rules, perhaps should we tackle 
the issue of "exposing" the rules in the context of 
https://issues.apache.org/jira/browse/FLINK-21456?
   
   
   Yes of course, my mistake, thought those casts work end to end now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to