mayuehappy commented on a change in pull request #17525:
URL: https://github.com/apache/flink/pull/17525#discussion_r742142498
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -460,22 +461,66 @@ public void testGetKeysAndNamespaces() throws Exception {
backend.getPartitionedState(
ns1,
StringSerializer.INSTANCE,
- new ValueStateDescriptor<>(fieldName,
IntSerializer.INSTANCE));
+ new ValueStateDescriptor<>(
+ valueStateFieldName,
IntSerializer.INSTANCE));
+
+ MapState<Integer, Integer> keyedState2 =
Review comment:
In addition, I observed that similar tests in StateBackendTestBase seem
to have some duplicate codes.(eg `testListStateRestoreWithWrongSerializers`\
`testValueStateRestoreWithWrongSerializers`
`testMapStateRestoreWithWrongSerializers`)
So maybe it's also fine to add a new test as
`#testMapStateGetKeysAndNamespace` just like` #testMapStateGetKeys ` or do u
have some other greater suggestions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
