AHeise commented on pull request #17521:
URL: https://github.com/apache/flink/pull/17521#issuecomment-958774452


   Sorry for coming back so late: I still don't quite understand how the flow 
is supposed to look like.
   
   Let's say I have a user.jar that through DSL depends on flink-kafka and 
flink-kinesis, both of them use incompatible guava. Now with your approach, the 
same user.jar is loaded through 2 classloaders to access kafka and kinesis. Did 
I get that right?
   
   What I fail to understand is how the incompatible version of Guava are put 
into the user.jar. If I just shade without relocation then one Guava version 
simply wins by overwriting the files. So you need to relocate Guava into 
kafka.guava and kinesis.guava. But at that point, I don't see the need for 
separate CL anymore.
   
   So I'm missing a piece of information here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to