CrynetLogistics commented on a change in pull request #17687:
URL: https://github.com/apache/flink/pull/17687#discussion_r743047568
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java
##########
@@ -49,6 +50,28 @@
public abstract class AsyncSinkBase<InputT, RequestEntryT extends Serializable>
implements Sink<InputT, Void, Collection<RequestEntryT>, Void> {
+ protected final ElementConverter<InputT, RequestEntryT> elementConverter;
+ protected final int maxBatchSize;
+ protected final int maxInFlightRequests;
+ protected final int maxBufferedRequests;
+ protected final long flushOnBufferSizeInBytes;
+ protected final long maxTimeInBufferMS;
Review comment:
I would have thought the concrete implementation of the sink would need
to access these values when creating the `SinkWriter`? e.g. here
`flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java`
on line 111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
