rkhachatryan commented on a change in pull request #17387:
URL: https://github.com/apache/flink/pull/17387#discussion_r744588199
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -2764,6 +2821,14 @@ private TestingTaskExecutor
createTestingTaskExecutor(TaskManagerServices taskMa
private TestingTaskExecutor createTestingTaskExecutor(
TaskManagerServices taskManagerServices, HeartbeatServices
heartbeatServices) {
+ return createTestingTaskExecutor(
+ taskManagerServices, heartbeatServices,
createUnregisteredTaskManagerMetricGroup());
+ }
+
+ private TestingTaskExecutor createTestingTaskExecutor(
Review comment:
This adds a new overloaded `createTestingTaskExecutor` version with an
additional argument `TaskManagerMetricGroup metricGroup`. The value for
argument differs depending on caller
(`createUnregisteredTaskManagerMetricGroup` vs a "real" `metricGroup` in
`createTaskExecutorTestingContext`) - in the same commit. So I think it's
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
