JingsongLi commented on a change in pull request #17509:
URL: https://github.com/apache/flink/pull/17509#discussion_r746186312
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/window/processors/RowTimeWindowRankProcessor.java
##########
@@ -81,7 +81,7 @@
private transient JoinedRowData reuseOutput;
private transient GenericRowData reuseRankRow;
- public WindowRankProcessor(
+ public RowTimeWindowRankProcessor(
Review comment:
Do we really need change class name? This will break compatibility.
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SlicingWindowOperator.java
##########
@@ -116,6 +121,9 @@
/** The tracked processing time triggered last time. */
private transient long lastTriggeredProcessingTime;
+ /** The operator state to store watermark. */
+ private ListState<Long> watermarkState;
Review comment:
transient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
