fapaul commented on a change in pull request #17696: URL: https://github.com/apache/flink/pull/17696#discussion_r746721562
########## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java ########## @@ -154,20 +161,6 @@ public void close() { "Close without timeout is now allowed because it can leave lingering Kafka threads."); } - @Override - public void close(long timeout, TimeUnit unit) { - synchronized (producerClosingLock) { - kafkaProducer.close(timeout, unit); - if (LOG.isDebugEnabled()) { - LOG.debug( - "Closed internal KafkaProducer {}. Stacktrace: {}", - System.identityHashCode(this), - Joiner.on("\n").join(Thread.currentThread().getStackTrace())); - } - closed = true; - } - } - Review comment: Why should be it dead code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org