lindong28 commented on a change in pull request #24:
URL: https://github.com/apache/flink-ml/pull/24#discussion_r747318831
##########
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/params/knn/KnnClassifierParams.java
##########
@@ -0,0 +1,4 @@
+package org.apache.flink.ml.params.knn;
+
+/** knn train parameters. */
+public interface KnnClassifierParams<T> extends KnnTrainParams<T>,
KnnPredictParams<T> {}
Review comment:
Model's action is currently expressed by the API `Model::transform`. It
is probably simpler to avoid introducing multiple names for the same thing
(e.g. predict/transform).
And if we believe there is semantic difference between classifier, regressor
and estimator, which I believe makes sense, it is probably useful to explicitly
add abstract classes and express the semantics difference via API and Java doc,
as is the case in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
