[
https://issues.apache.org/jira/browse/FLINK-24886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442638#comment-17442638
]
jackylau edited comment on FLINK-24886 at 11/12/21, 9:56 AM:
-------------------------------------------------------------
we can fix it 2 ways
# modify the comments 10m -> 10min
{code:java}
"Time after which cached stats are cleaned up if not
accessed. It can"
+ " be specified using notation: \"100 s\",
\"10 m\"."); {code}
2. modify the TimeUtils to support it.
I think the 2 is better. Because it fits user habits. And i am wiling to fix it
was (Author: jackylau):
we can fix it 2 ways
# modify the comments 10m -> 10min
{code:java}
"Time after which cached stats are cleaned up if not
accessed. It can"
+ " be specified using notation: \"100 s\",
\"10 m\"."); {code}
# modify the TimeUtils to support it.
I think the 2 is better. Because it fits user habits. And i am wiling to fix it
> flink flame args bug, may we need to modify TimeUtils to supports m
> -------------------------------------------------------------------
>
> Key: FLINK-24886
> URL: https://issues.apache.org/jira/browse/FLINK-24886
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
> Affects Versions: 1.14.0, 1.13.3
> Reporter: jackylau
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
> Attachments: image-2021-11-12-17-38-28-969.png
>
>
> When I refer to the configuration documentation setting
> rest.flamegraph.cleanup-interval to "10 m", it will be bug
>
> {code:java}
> public static final ConfigOption<Duration> FLAMEGRAPH_CLEANUP_INTERVAL =
> key("rest.flamegraph.cleanup-interval")
> .durationType()
> .defaultValue(Duration.ofMinutes(10))
> .withDescription(
> "Time after which cached stats are cleaned up if not
> accessed. It can"
> + " be specified using notation: \"100 s\",
> \"10 m\"."); {code}
>
>
> !image-2021-11-12-17-38-28-969.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
