twalthr commented on a change in pull request #17738:
URL: https://github.com/apache/flink/pull/17738#discussion_r748334307
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -236,6 +471,35 @@
RawValueData.fromObject(
LocalDateTime.parse("2020-11-11T18:08:01.123")),
StringData.fromString("2020-11-11T18:08:01.123")),
+ CastTestSpecBuilder.testCastTo(DECIMAL(5, 3))
+ .fromCase(
+ DECIMAL(4, 3),
+ DecimalData.fromBigDecimal(new
BigDecimal("9.87"), 4, 3),
+ DecimalData.fromBigDecimal(new
BigDecimal("9.870"), 5, 3))
+ .fromCase(
+ TINYINT(),
+ (byte) -1,
+ DecimalData.fromBigDecimal(new
BigDecimal("-1.000"), 5, 3))
Review comment:
What you could have done is simply `decimal("-1.000")` or
`decimal("-1.000", 5, 3)` and abstract away the verbose
`DecimalData.fromBigDecimal(new BigDecimal("-1.000"), 5, 3)` for readbility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
