curcur commented on a change in pull request #17462:
URL: https://github.com/apache/flink/pull/17462#discussion_r749048095
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendTestUtils.java
##########
@@ -158,16 +155,15 @@ public static void testMaterializedRestore(
keyedBackend.setCurrentKey(2);
state.update(new StateBackendTestBase.TestPojo("u2", 2));
- awaitMaterialization(keyedBackend, env.getMainMailboxExecutor());
+ // trigger materialization manually
+ periodicMaterializationManager.triggerMaterialization();
Review comment:
It is a bit confusing unless digging into details how
`triggerMaterialization()` is implemented. Because we also call schedule
materialization in `triggerMaterialization()`.
Here, I mean each scheduling of materialization is triggered manually. It
improves the readabilities of the test. I am a bit inclined to explicit
commented here or if you have better suggestions to improve the comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
