matriv commented on pull request #17771: URL: https://github.com/apache/flink/pull/17771#issuecomment-968993409
> Hi, thanks for you to review my code, @matriv :) .I want to do some responses to your review. > > 1. `LogicalTypeCasts ` seems useless in the case "SELECT 1 = '1' FROM xxx" because the case doesn't call the function CAST, so the CAST doesn't work, and can't detect this bad pattern. However, "SELECT 1 = '1' FROM xxx" is always "false", that is what I want to avoid and to throw an exception to remain users. Please bear with me, maybe I'm still missing the whole context. Can we just test that `SELECT x = y` produces the correct implicit cast under the scenes, and then just make sure that this implicit cast is supported in `LogicalTypeCasts`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
