beyond1920 commented on a change in pull request #17637:
URL: https://github.com/apache/flink/pull/17637#discussion_r750106558
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/ConvertToNotInOrInRule.scala
##########
@@ -184,6 +188,54 @@ class ConvertToNotInOrInRule
case _ => rexNodes.size >= THRESHOLD
}
}
+
Review comment:
Sorry, I checked the scalar code in currently
`ConvertToNotInOrInRule.scala`, they are same with the above java code.
Could we move this method to `FlinkRexBuilder`, and overwrite the makeIn
method of parent class?
Then we could avoid this bug appears in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
