Airblader opened a new pull request #17808:
URL: https://github.com/apache/flink/pull/17808
## What is the purpose of the change
This is a few commits which aim to slowly improve the code quality in Flink
UI by improving type safety and various smaller fixes. With the exception of
the last commit all changes are non-functional, and the last commit only fixes
a bug which causes an error in the browser console.
This PR also adds `angular-testing-library` which will make writing tests in
the future easier.
## Brief change log
See individual commits.
## Verifying this change
Flink UI doesn't yet have tests. I added a couple here due to the addition
of `angular-testing-library`, but we need to add more tests, of course.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
