fapaul commented on a change in pull request #17776:
URL: https://github.com/apache/flink/pull/17776#discussion_r750198667
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSourceSplit.java
##########
@@ -84,16 +91,54 @@
//
--------------------------------------------------------------------------------------------
+ /** @deprecated You should use {@link #FileSourceSplit(String, Path, long,
long, long, long)} */
+ public FileSourceSplit(String id, Path filePath, long offset, long length)
{
Review comment:
Nit: Can you rearrange the ctors that the deprecated ones are listed
last?
##########
File path: docs/content/docs/connectors/table/filesystem.md
##########
@@ -126,6 +126,21 @@ The following connector metadata can be accessed as
metadata columns in a table
<td><code>STRING NOT NULL</code></td>
<td>Full path of the input file.</td>
</tr>
+ <tr>
+ <td><code>filename</code></td>
+ <td><code>STRING NOT NULL</code></td>
+ <td>Name of the file, that is the farthest element from the root of the
filepath.</td>
+ </tr>
+ <tr>
+ <td><code>size</code></td>
+ <td><code>BIGINT NOT NULL</code></td>
+ <td>Size of the file.</td>
Review comment:
We should probably be more precise here is it a row count or byte count?
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveSourceSplit.java
##########
@@ -53,11 +53,18 @@ public HiveSourceSplit(
new Path(fileSplit.getPath().toString()),
fileSplit.getStart(),
fileSplit.getLength(),
+ 0,
+ 0,
fileSplit.getLocations(),
readerPosition,
hiveTablePartition);
}
+ /**
+ * @deprecated You should use {@link #HiveSourceSplit(String, Path, long,
long, long, long,
+ * String[], CheckpointedPosition, HiveTablePartition)}
+ */
+ @Deprecated
Review comment:
Nit: maybe also rearrange the ctors
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/FileSystemITCaseBase.scala
##########
@@ -368,6 +372,63 @@ trait FileSystemITCaseBase {
)
}
+ @Test
+ def testReadAllMetadata(): Unit = {
Review comment:
Why are these tests in scala? 🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
