nicoweidner commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750499397
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/timeline/job-timeline.component.ts
##########
@@ -143,16 +189,18 @@ export class JobTimelineComponent implements
AfterViewInit, OnDestroy {
this.mainChartInstance.tooltip({
title: 'name'
});
- this.mainChartInstance.on('click', (e: SafeAny) => {
+ this.mainChartInstance.on('click', (e: { x: number; y: number }) => {
if (this.mainChartInstance.getSnapRecords(e).length) {
- const data = (this.mainChartInstance.getSnapRecords(e)[0] as
SafeAny)._origin;
+ const data = ((this.mainChartInstance.getSnapRecords(e)[0] as unknown)
as {
Review comment:
Sorry, my message was a bit garbled. What I meant to point out was that
it's rather strange that we apparently have a `number[]`, but then suddenly
access property `._origin`. But you already addressed that in your answer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
