slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r751988625
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -144,12 +151,16 @@
return substrings.toArray(new BinaryStringData[0]);
}
- /** Decide boolean representation of a string. */
- public static Boolean toBooleanSQL(BinaryStringData str) {
+ /** Parse a {@link StringData} to boolean. */
+ public static boolean toBoolean(BinaryStringData str) throws
TableException {
Review comment:
I can't easily extract the changes of `BinaryStringDataUtil` without
creating commits that won't build, I renamed the commit where the big changes
happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
