[ 
https://issues.apache.org/jira/browse/FLINK-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446589#comment-17446589
 ] 

Ahmed Hamdy commented on FLINK-24905:
-------------------------------------

[~dannycranmer] yes, exactly the alternative approach is to retain support for 
the legacy connector using a specified options
{code:java}
CREATE TABLE orders (
 ...
)
WITH (
'connector' = 'kinesis',
'stream' = 'orders',
'sink.use-kinesis-producer = true'
 ...
) {code}
The assumption is that the configurations are not going to be backward 
compatible as {{sink.producer.*}} options are only going to be valid if used 
with the legacy connector flag. 
Ignoring the {{sink.producer.*}} is still an option for backward compatibility 
but it seems misleading if they are not actually used by the underlying 
implementation.

> KDS implementation of Async Sink Table API
> ------------------------------------------
>
>                 Key: FLINK-24905
>                 URL: https://issues.apache.org/jira/browse/FLINK-24905
>             Project: Flink
>          Issue Type: New Feature
>          Components: Connectors / Kinesis
>            Reporter: Zichen Liu
>            Assignee: Ahmed Hamdy
>            Priority: Major
>             Fix For: 1.15.0
>
>
> h2. Motivation
> *User stories:*
> As a Flink user, I’d like to use the Table API for the new Kinesis Data 
> Streams  sink.
> *Scope:*
>  * Introduce {{AsyncDynamicTableSink}} that enables Sinking Tables into Async 
> Implementations.
>  * Implement a new {{KinesisDynamicTableSink}} that uses 
> {{KinesisDataStreamSink}} Async Implementation and implements 
> {{{}AsyncDynamicTableSink{}}}.
>  * The implementation introduces Async Sink configurations as optional 
> options in the table definition, with default values derived from the 
> {{KinesisDataStream}} default values.
>  * Unit/Integration testing. modify KinesisTableAPI tests for the new 
> implementation, add unit tests for {{AsyncDynamicTableSink}} and 
> {{KinesisDynamicTableSink}} and {{{}KinesisDynamicTableSinkFactory{}}}.
>  * Java / code-level docs.
> h2. References
> More details to be found 
> [https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to