[ https://issues.apache.org/jira/browse/FLINK-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flink Jira Bot updated FLINK-14565: ----------------------------------- Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available (was: auto-deprioritized-major pull-request-available stale-minor) Priority: Not a Priority (was: Minor) This issue was labeled "stale-minor" 7 days ago and has not received any updates so it is being deprioritized. If this ticket is actually Minor, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > Shutdown SystemResourcesCounter on (JM|TM)MetricGroup closed > ------------------------------------------------------------ > > Key: FLINK-14565 > URL: https://issues.apache.org/jira/browse/FLINK-14565 > Project: Flink > Issue Type: Bug > Components: Runtime / Metrics > Reporter: Zili Chen > Priority: Not a Priority > Labels: auto-deprioritized-major, auto-deprioritized-minor, > pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently, we start SystemResourcesCounter when initialize > (JM|TM)MetricGroup. This thread doesn't exit on (JM|TM)MetricGroup closed and > even there is not exit logic of them. > It possibly causes thread leak. For example, on our platform which supports > previewing sample SQL execution, it starts a MiniCluster in the same process > as the platform. When the preview job finished MiniCluster closed and also > (JM|TM)MetricGroup. However these SystemResourcesCounter threads remain. > I propose when creating SystemResourcesCounter, track it in > (JM|TM)MetricGroup, and on (JM|TM)MetricGroup closed, shutdown > SystemResourcesCounter. This way, we survive from thread leaks. > CC [~chesnay] [~trohrmann] -- This message was sent by Atlassian Jira (v8.20.1#820001)