dmvk commented on a change in pull request #17607: URL: https://github.com/apache/flink/pull/17607#discussion_r755118309
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java ########## @@ -87,18 +88,19 @@ private static final Logger LOG = LoggerFactory.getLogger(ZooKeeperStateHandleStore.class); - @VisibleForTesting - static final Set<Class<? extends KeeperException>> PRE_COMMIT_EXCEPTIONS = - newHashSet( - KeeperException.NodeExistsException.class, - KeeperException.BadArgumentsException.class, - KeeperException.NoNodeException.class, - KeeperException.NoAuthException.class, - KeeperException.BadVersionException.class, - KeeperException.AuthFailedException.class, - KeeperException.InvalidACLException.class, - KeeperException.SessionMovedException.class, - KeeperException.NotReadOnlyException.class); + /** Pre-commit exceptions that don't imply data inconsistency. */ + private static final Set<Class<? extends KeeperException>> SAFE_PRE_COMMIT_EXCEPTIONS = + new HashSet<>( + Arrays.asList( + KeeperException.NodeExistsException.class, + KeeperException.BadArgumentsException.class, + KeeperException.NoNodeException.class, + KeeperException.NoAuthException.class, + KeeperException.BadVersionException.class, + KeeperException.AuthFailedException.class, + KeeperException.InvalidACLException.class, + KeeperException.SessionMovedException.class, + KeeperException.NotReadOnlyException.class)); Review comment: I'm just desperate here... I'd say except `NoNodeException` and `BadArgumentsException` all of them are "potentially" unsafe if preceded by connection loss. I'd be in favor of removing this list completely as it's really hard to reason about. I'd even suggest reverting https://issues.apache.org/jira/browse/FLINK-22494 and coming up with a different solution. (discarding checkpoint & validating metadata before recovery) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org