Aitozi commented on a change in pull request #41:
URL: https://github.com/apache/flink-benchmarks/pull/41#discussion_r755120413
##########
File path:
src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
##########
@@ -52,10 +54,25 @@
final ThreadLocalRandom random = ThreadLocalRandom.current();
@Param({"HEAP", "ROCKSDB"})
- protected StateBackendBenchmarkUtils.StateBackendType backendType;
+ private StateBackendBenchmarkUtils.StateBackendType backendType;
+
+ @Param({StateBenchmarkConstants.defaultStateDataDirPath})
+ private String stateDataDirPath;
Review comment:
I didn't notice it. Now I prefer to not use `@Param` for this . Instead
of using environmental variable, Can we add a benchmark conf as I mentioned in
[FLINK-24967](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-24967)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
