pnowojski commented on a change in pull request #41:
URL: https://github.com/apache/flink-benchmarks/pull/41#discussion_r755179227
##########
File path:
src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
##########
@@ -52,10 +54,25 @@
final ThreadLocalRandom random = ThreadLocalRandom.current();
@Param({"HEAP", "ROCKSDB"})
- protected StateBackendBenchmarkUtils.StateBackendType backendType;
+ private StateBackendBenchmarkUtils.StateBackendType backendType;
+
+ @Param({StateBenchmarkConstants.defaultStateDataDirPath})
+ private String stateDataDirPath;
Review comment:
I think either of those options would work, depends on what we want to
achieve? I think using `@Params` makes sense if we really want to present the
results from different configurations side by side, especially in the WebUI or
in the continuous regression testing scripts. However if there are many many
different constants that you would like to change, it probably doesn't make
sense to keep them all separately as `@Params`, as it would simply explode the
number of tests (jmh is testing all combinations of params).
Having said all of that, a dedicated config file might be a not a bad
solution. For now there can be a single configuration file that anyone can
overwrite as he chooses. If we ever decide to present the results from
different configs side by side, we can do this via `@Param` `preset`, where
`preset` would be a name of one of those config files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
