weibozhao commented on a change in pull request #24:
URL: https://github.com/apache/flink-ml/pull/24#discussion_r755673679
##########
File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java
##########
@@ -64,7 +64,7 @@ public Param(
* @return A json-formatted string.
*/
public String jsonEncode(T value) throws IOException {
- return ReadWriteUtils.OBJECT_MAPPER.writeValueAsString(value);
+ return ReadWriteUtils.OBJECT_MAPPER.toJson(value);
Review comment:
After discuss with lindong, I will modify this code. using
writeValueAsString may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
