Airblader opened a new pull request #17898:
URL: https://github.com/apache/flink/pull/17898
## What is the purpose of the change
This PR resolves most of the architectural violations within `flink-table`,
specifically those where the correct course of action is clear. This generally
falls into the following two categories:
* Mark nested classes and enums of `@PublicEvolving` classes as
`@PublicEvolving` if they are return or argument types of public methods of the
outer class. This explicit annotation is necessary also for the binary
compatibility checker, i.e. the paradigm should be: annotate nested types
explicitly as well. Given that de-facto this was already the semantics within
Table API, this is a trivial change.
* Replace `@VisibleForTesting` with `@Internal` where methods are actually
called from production code outside the class.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
