Zakelly commented on a change in pull request #17874:
URL: https://github.com/apache/flink/pull/17874#discussion_r757247965



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java
##########
@@ -91,10 +108,13 @@ public RocksDBResourceContainer(
 
     /** Gets the RocksDB {@link DBOptions} to be used for RocksDB instances. */
     public DBOptions getDbOptions() {
-        // initial options from pre-defined profile
-        DBOptions opt = predefinedOptions.createDBOptions(handlesToClose);
+        // initial options from common profile
+        DBOptions opt = createDBOptions();
         handlesToClose.add(opt);
 
+        // load configurable options on top of pre-defined profile
+        opt = getDBOptionsFromConfigurableOptions(opt, handlesToClose);

Review comment:
       Sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to