Tartarus0zm commented on a change in pull request #17826:
URL: https://github.com/apache/flink/pull/17826#discussion_r757279531
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveParallelismInference.java
##########
@@ -63,10 +63,10 @@ int limit(Long limit) {
return parallelism;
}
- if (limit != null) {
- parallelism = Math.min(parallelism, (int) (limit / 1000));
+ if (!infer || limit == null) {
Review comment:
I think we only add ``` if (!infer && limit == null) { return
parallelism; } ``` is better,
then the `limit` still work;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
