zhipeng93 commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r758021592
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.classification.naivebayes; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.api.common.serialization.Encoder; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.SimpleStreamFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.types.Row; + +import com.esotericsoftware.kryo.io.Input; +import com.esotericsoftware.kryo.io.Output; + +import java.io.IOException; +import java.io.OutputStream; +import java.io.Serializable; +import java.util.HashMap; +import java.util.Map; + +/** + * The model data of {@link NaiveBayesModel}. + * + * <p>This class also provides methods to convert model data between Table and Datastream, and + * classes to save/load model data. + */ +public class NaiveBayesModelData implements Serializable { + public final Map<Double, Double>[][] theta; + public final double[] piArray; + public final int[] labels; + + public NaiveBayesModelData(Map<Double, Double>[][] theta, double[] piArray, int[] labels) { + this.theta = theta; + this.piArray = piArray; + this.labels = labels; + } + + /** Converts the provided modelData Datastream into corresponding Table. */ + public static Table getModelDataTable( + StreamTableEnvironment tEnv, DataStream<NaiveBayesModelData> stream) { Review comment: Can we get `tEnv` from the input data stream rather than passing it as a param? ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.classification.naivebayes; + +import org.apache.flink.api.common.functions.MapFunction; +import org.apache.flink.api.common.serialization.Encoder; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.SimpleStreamFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.types.Row; + +import com.esotericsoftware.kryo.io.Input; +import com.esotericsoftware.kryo.io.Output; + +import java.io.IOException; +import java.io.OutputStream; +import java.io.Serializable; +import java.util.HashMap; +import java.util.Map; + +/** + * The model data of {@link NaiveBayesModel}. + * + * <p>This class also provides methods to convert model data between Table and Datastream, and + * classes to save/load model data. + */ +public class NaiveBayesModelData implements Serializable { + public final Map<Double, Double>[][] theta; + public final double[] piArray; + public final int[] labels; + + public NaiveBayesModelData(Map<Double, Double>[][] theta, double[] piArray, int[] labels) { + this.theta = theta; + this.piArray = piArray; + this.labels = labels; + } + + /** Converts the provided modelData Datastream into corresponding Table. */ + public static Table getModelDataTable( + StreamTableEnvironment tEnv, DataStream<NaiveBayesModelData> stream) { + return tEnv.fromDataStream(stream); + } + + /** Converts the provided modelData Table into corresponding DataStream. */ + public static DataStream<NaiveBayesModelData> getModelDataStream( + StreamTableEnvironment tEnv, Table table) { + return tEnv.toDataStream(table) Review comment: same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
