Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70327009
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -206,7 +206,13 @@ private void
deserializeRecordForCollectionAndUpdateState(UserRecord record)
final long approxArrivalTimestamp =
record.getApproximateArrivalTimestamp().getTime();
final T value = deserializer.deserialize(
- keyBytes, dataBytes, subscribedShard.getStreamName(),
record.getSequenceNumber(), approxArrivalTimestamp);
+ keyBytes,
+ dataBytes,
+ record.getPartitionKey(),
+ record.getSequenceNumber(),
+ approxArrivalTimestamp,
+ subscribedShard.getStreamName(),
+ subscribedShard.getShard().getShardId());
--- End diff --
Fixed the indention.
I don't think that having a separate final variable for this will improve
the performance a lot. The methods are computing anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
