alpreu commented on a change in pull request #17964:
URL: https://github.com/apache/flink/pull/17964#discussion_r760917652
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactory.java
##########
@@ -321,7 +321,9 @@ private static void validatePKConstraints(
&& format.getChangelogMode().containsOnly(RowKind.INSERT)) {
Configuration configuration = Configuration.fromMap(options);
String formatName =
-
configuration.getOptional(FactoryUtil.FORMAT).orElse(options.get(VALUE_FORMAT));
+ configuration
+ .getOptional(FactoryUtil.FORMAT)
+ .orElse(configuration.get(VALUE_FORMAT));
Review comment:
We have a test that uses the `FactoryUtil.FORMAT`, I tried adding the
same test with passing in the `KafkaConnectorOptions.VALUE_FORMAT` but other
validations always fail before we would reach this exception. I believe the
code path is currently not reachable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
