wangyang0918 commented on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-991677454
IIRC, not only the labels, but also pod names, services names, have the most
63 characters limitation. So we might need to have `generateBasedOnClusterId`
for all the specific cases.
> is the case of adding new k8s prefixes unlikely?
Yes, we might introduce new or change some labels, names in the future,
which will make the length pre-check for cluster-id not work again. So I agree
with you that moving all the generation of labels, pod names, service
names to `AbstractKubernetesParameters` is a right direction. But it might
not be very easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
