[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379407#comment-15379407 ]
ASF GitHub Bot commented on FLINK-4184: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2220#discussion_r70977551 --- Diff: flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java --- @@ -74,6 +75,15 @@ protected ScheduledDropwizardReporter() { } // ------------------------------------------------------------------------ + // Getters + // ------------------------------------------------------------------------ + + // used for testing purposes + Map<Counter, String> getCounters() { --- End diff -- We can, if we mark the counters, gauges and histograms fields as protected. But then we would expose the implementation details to all sub-classes instead of having a getter which is package private. I think the latter option is a bit nicer, because it hides the implementation details. > Ganglia and GraphiteReporter report metric names with invalid characters > ------------------------------------------------------------------------ > > Key: FLINK-4184 > URL: https://issues.apache.org/jira/browse/FLINK-4184 > Project: Flink > Issue Type: Bug > Components: Metrics > Affects Versions: 1.1.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Fix For: 1.1.0 > > > Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with > names which contain invalid characters. For example, quotes are not filtered > out which can be problematic for Ganglia. Moreover, dots are not replaced > which causes Graphite to think that an IP address is actually a scoped metric > name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)