dawidwys commented on a change in pull request #18092:
URL: https://github.com/apache/flink/pull/18092#discussion_r770438174
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1200,48 +1200,63 @@ public boolean receiveAcknowledgeMessage(
*/
private void completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
throws CheckpointException {
- final long checkpointId = pendingCheckpoint.getCheckpointId();
+ final long checkpointId = pendingCheckpoint.getCheckpointID();
final CompletedCheckpoint completedCheckpoint;
final CompletedCheckpoint lastSubsumed;
+ final CheckpointProperties props = pendingCheckpoint.getProps();
// As a first step to complete the checkpoint, we register its state
with the registry
- Map<OperatorID, OperatorState> operatorStates =
pendingCheckpoint.getOperatorStates();
- SharedStateRegistry sharedStateRegistry =
completedCheckpointStore.getSharedStateRegistry();
- sharedStateRegistry.registerAll(operatorStates.values());
+ // we do not
+ if (!props.isSavepoint()) {
Review comment:
I'd say other way around. We do not register any savepoints in the
CheckpointStore (neither intermediate, nor the final/synchronous), thus we
should not register their state into shared state.
However we do want to send `notifyCheckpointComplete` for `synchronous`
savepoints, because we end the job afterwards and we should leave the system in
a consistent state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
