yangjunhan commented on a change in pull request #18148: URL: https://github.com/apache/flink/pull/18148#discussion_r773623624
########## File path: flink-runtime-web/web-dashboard/src/app/pages/job-manager/thread-dump/job-manager-thread-dump.component.ts ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { ChangeDetectorRef, Component, OnInit, ChangeDetectionStrategy, OnDestroy } from '@angular/core'; +import { Subject } from 'rxjs'; +import { takeUntil } from 'rxjs/operators'; + +import { EditorOptions } from 'ng-zorro-antd/code-editor/typings'; +import { flinkEditorOptions } from 'share/common/editor/editor-config'; + +import { JobManagerService } from 'services'; + +@Component({ + selector: 'flink-job-manager-thread-dump', + templateUrl: './job-manager-thread-dump.component.html', + styleUrls: ['./job-manager-thread-dump.component.less'], + changeDetection: ChangeDetectionStrategy.OnPush +}) +export class JobManagerThreadDumpComponent implements OnInit, OnDestroy { + public readonly editorOptions: EditorOptions = flinkEditorOptions; + + public dump = ''; + public loading = true; + + private readonly destroy$ = new Subject<void>(); + + constructor(private readonly jobManagerService: JobManagerService, private readonly cdr: ChangeDetectorRef) {} + + public ngOnInit(): void { + this.reload(); + } + + public ngOnDestroy(): void { + this.destroy$.next(); + this.destroy$.complete(); + } + + public reload(): void { + this.loading = true; + this.cdr.markForCheck(); + if (this.jobManagerService) { + this.jobManagerService + .loadThreadDump() + .pipe(takeUntil(this.destroy$)) + .subscribe( + data => { + this.loading = false; + this.dump = data; + this.cdr.markForCheck(); + }, + () => { + this.cdr.markForCheck(); Review comment: you need to set loading false in error as well. Another way is using `finalize` rxjs operator in the pipe so that you do not need to set loading false in two places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
