[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463826#comment-17463826 ]
Wenlong Lyu commented on FLINK-25409: ------------------------------------- hi, [~MartijnVisser] this ticket may be not relevant to the new source/sink API and FLIP-33, lookup source is a SQL concept. +1 for common LookupFunctionWithCache. It can help unify the caching config of different connectors and reduce duplicate work on connector development. In addition, we can add one more metric to measure lookup latency per record. > Add cache metric to LookupFunction > ---------------------------------- > > Key: FLINK-25409 > URL: https://issues.apache.org/jira/browse/FLINK-25409 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Ecosystem > Reporter: Yuan Zhu > Priority: Major > > Since we encounter performance problem when lookup join in production env > frequently, adding metrics to monitor Lookup function cache is very helpful > to troubleshoot. -- This message was sent by Atlassian Jira (v8.20.1#820001)