[ 
https://issues.apache.org/jira/browse/FLINK-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385797#comment-15385797
 ] 

ASF GitHub Bot commented on FLINK-4229:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2266#discussion_r71517800
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
 ---
    @@ -50,9 +50,10 @@
        public void testJobManagerMetricAccess() throws Exception {
                Deadline deadline = new FiniteDuration(2, 
TimeUnit.MINUTES).fromNow();
                Configuration flinkConfiguration = new Configuration();
    -           
    +
    +           
flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_CLASS, 
"org.apache.flink.metrics.reporter.JMXReporter");
                
flinkConfiguration.setString(ConfigConstants.METRICS_SCOPE_NAMING_JM_JOB, 
"jobmanager.<job_name>");
    -           flinkConfiguration.setString(ConfigConstants.METRICS_JMX_PORT, 
"9060-9075");
    +           
flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "-port 
9060-9075");
    --- End diff --
    
    arguments are prefixed with a double dash `--`. 


> Do not start Metrics Reporter by default
> ----------------------------------------
>
>                 Key: FLINK-4229
>                 URL: https://issues.apache.org/jira/browse/FLINK-4229
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> By default, we start a JMX reported that binds to a port and comes with extra 
> threads. 
> We should not start any reported by default to keep the overhead to a minimum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to