imaffe commented on pull request #18014: URL: https://github.com/apache/flink/pull/18014#issuecomment-1000023030
> > @PatrickRen Updated ~ > > @imaffe > > The text used in the old JUnit4 should be more like an error msg than description before the test. It should be better to use withFailMessage(..) in this case. I think what you have done before this change was actually the right one. @PatrickRen WDYT? > > Reference: https://junit.org/junit4/javadoc/4.8/org/junit/Assert.html#assertEquals(java.lang.String,%20long,%20long). The message is used for AssertionError. Yeah I know it is like error message, but I think from @PatrickRen as() is the right way to show description when failed plus the original "Expected xxx but got xxx". (When test passes the description can be ignored) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
