[
https://issues.apache.org/jira/browse/FLINK-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387651#comment-15387651
]
ASF GitHub Bot commented on FLINK-4239:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2278
[FLINK-4239] Set Default Allowed Lateness to Zero and Make Triggers N…
R: @kl0u for review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-fix-lateness-purging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2278
----
commit e3da8926a33773564d668e105a1d9f268e6b0aed
Author: Aljoscha Krettek <[email protected]>
Date: 2016-07-21T13:10:54Z
[FLINK-4239] Set Default Allowed Lateness to Zero and Make Triggers
Non-Purging
----
> Set Default Allowed Lateness to Zero and Make Triggers Non-Purging
> ------------------------------------------------------------------
>
> Key: FLINK-4239
> URL: https://issues.apache.org/jira/browse/FLINK-4239
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> In preparation for upcoming changes in 1.2 we should set the default allowed
> lateness to zero and make all built-in triggers non-purging by default.
> Currently, {{EventTimeTrigger}} and {{ProcessingTimeTrigger}} purge when they
> fire. This leads to unexpected behavior when a user sets some meaningful
> allowed lateness. The behavior will be that the window is purged when firing
> and the state will not actually be kept within the allowed lateness.
> Changing the behavior to non-purging requires changing the default allowed
> lateness from {{Long.MAX_VALUE}} to {{0}}. Otherwise we would have memory
> leaks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
