Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2226
  
    Actually, we do not even have to move the JobID, if the runtime-specific 
parts (the component metric groups) are in `flink-runtime`. That part, I 
believe, we should do anyways.
    
    It certainly is nice to have a complete "self-contained" metrics project 
with everything. That way, people can actually build their own metrics tooling 
using some of the implementation classes, or they can set up self-contained 
tests for reporters (without having flink-core) as a test dependency. If it 
were not for the `NetUtils`, I would suggest to go for that. The 
`Preconditions` are used only for `checkNotNull`, which one can do via 
`java.util.Objects.requireNonNull` as well.
    
    On the other side of the argument are the `NetUtils` (one utility function 
for port ranges) and making the MetricRegistry use MetricConfig in all places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to