afedulov edited a comment on pull request #17598: URL: https://github.com/apache/flink/pull/17598#issuecomment-1007555875
@fapaul I addressed all of the comments. The only remaining open points from my perspective: - clarify if imposing a strict `Serializable` requirement on the `Converter` interface is desirable. I believe Arvid mentioned that shifting this concern to factories was described as "better design" (we do not have factories for the existing converters though). - clarify if there should also be an explicit `CsvWriterFactory` implementation added of `BulkWriter.Factory<T>` for consistency (similar to `ParquetWriterFactory<T>` and `AvroWriterFactory<T>`). Currently we just used a functional interface via a lambda. - open a follow-up ticket for projection pushdown support for the previously existing ser/de-schema-based implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
