xintongsong commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1008252314
@galenwarren, Thanks for updating the PR. The PR looks very close to a mergable state. The tests look really good to me. I have only a few minor tests, majorly relates to exposure of implementation internal states for testing. Let me try to list the remaining actions before merging this PR. - Addressing the last comments. - Clean-up the commit history. (This can be as simple as squash everything into a big commit, with a proper descriptive message.) - Wait a bit longer for the compiling issue, see if @zentol has any insight when he comes back. Concerning the documentation, we definitely need it for this new feature. It would be even better to revisiting the documentation for the GCS connectivity as a whole: the [existing GCS page](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/filesystems/gcs/), FLINK-25577 and this new recoverable writer. I'd suggest to work on the documentation in a separate JIRA, as this PR is already overlarge. We would need to get the documentation ready by feature freeze (Feb 6th), as required for all new features in the 1.15 release, so that people can start testing the features accordingly as soon as the freeze. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
