fapaul commented on a change in pull request #18302:
URL: https://github.com/apache/flink/pull/18302#discussion_r781214232
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java
##########
@@ -806,6 +809,54 @@ public void testConflictSlotSharingGroup() {
env.getStreamGraph();
}
+ @Test
+ public void testTrackTransformationsByIdentity() {
+ final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+ final Transformation<?> noopTransformation = env.fromSequence(1,
2).getTransformation();
+
+ final StreamGraphGenerator generator =
+ new StreamGraphGenerator(
+ Lists.newArrayList(
+ noopTransformation,
+ new
FailingTransformation(noopTransformation.hashCode())),
Review comment:
I do not think but having one dependency less is always favorable. I
used `Arrays.asList`.
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java
##########
@@ -806,6 +809,54 @@ public void testConflictSlotSharingGroup() {
env.getStreamGraph();
}
+ @Test
+ public void testTrackTransformationsByIdentity() {
+ final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+ final Transformation<?> noopTransformation = env.fromSequence(1,
2).getTransformation();
+
+ final StreamGraphGenerator generator =
+ new StreamGraphGenerator(
+ Lists.newArrayList(
+ noopTransformation,
+ new
FailingTransformation(noopTransformation.hashCode())),
Review comment:
I do not think but having one dependency less is always favorable. I use
`Arrays.asList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
