Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2123#discussion_r72076345
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
 ---
    @@ -84,12 +84,11 @@
         */
        private static int MAX_SAMPLE_LEN;
     
    -   static { loadGlobalConfigParams(); }
    -   
    -   protected static void loadGlobalConfigParams() {
    -           int maxSamples = 
GlobalConfiguration.getInteger(ConfigConstants.DELIMITED_FORMAT_MAX_LINE_SAMPLES_KEY,
    +
    +   protected static void loadConfigParameters(Configuration parameters) {
    --- End diff --
    
    According to the plugin which checks API changes, it is not breaking. I 
don't know whether this is a shortcoming of the plugin or actually ok. We can 
still keep the old method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to